common: refactor vncauth.c #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (i = 0; i < 8; i++) { | ||
| putc(encryptedPasswd[i], fp); | ||
| } | ||
| fwrite(encryptedPasswd, 1, sizeof(encryptedPasswd), fp); |
Check failure
Code scanning / CodeQL
Cleartext storage of sensitive information in file
There was a problem hiding this comment.
I have not changed that. Its storing the same bytes in the file as before.
The Ci is not wrong, but i am not making it worse.
|
@bk138 what is up with this PR? Do i need to change something? |
I haven't found the time yet to have a look, lotsa €€€-work to do. Will eventually check back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reorganized parts of the code to be more readable and probably more performant as well (one
fwriteandfreadinstead of single byte writes and reads).